Feat: eigenda client confirmation depth #819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
method is now no longer used anymore, and could be deprecated
…orumID eventually
only need tracing-id key now since v2 will do idempotency using blobHeader Also realized using same key for idempotency and tracing doesn't make sense, since one might want different requests to be traced idependently but use the same idempotency key
samlaf
changed the base branch from
master
to
style--improve-api-clients-comments
samlaf
force-pushed
the
style--improve-api-clients-comments
branch
from
795868e
to
5b39fe6
Compare
Base automatically changed from
style--improve-api-clients-comments
to
master
October 19, 2024 18:26
|
Closing in favor of #821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EBE-107.
Why are these changes needed?
Starting to upstream some of the eigenda-proxy features to eigenda-client.
This PR is needed for Layr-Labs/eigenda-proxy#187
Did not add a unit test, as I'm not a big fan of mock-based tests, which is the only pattern we have currently to test the eigenda-client. Added an e2e test on holesky instead, but this does not seem to be checked by any of our ci workflows... PR incoming (#820 ).
Checks